Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============7419349824985248324=="
MIME-Version: 1.0
Subject: Re: Review Request 20119: Updated policy for building against system
 dependencies.
From: "Timothy St. Clair" <tstclair@redhat.com>
To: "Benjamin Hindman" <benh@berkeley.edu>
Cc: "Timothy St. Clair" <tstclair@redhat.com>, "mesos" <dev@mesos.apache.org>
Date: Thu, 10 Apr 2014 19:24:42 -0000
Message-ID: <20140410192442.23650.77124@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Timothy St. Clair" <noreply@reviews.apache.org>
References: <20140409215249.20524.60851@reviews.apache.org>
In-Reply-To: <20140409215249.20524.60851@reviews.apache.org>
Reply-To: "Timothy St. Clair" <tstclair@redhat.com>

--===============7419349824985248324==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On April 9, 2014, 9:52 p.m., Benjamin Hindman wrote:
> > Here are the three uses cases I see being addressed here:
> > 
> > (1) Use everything bundled.
> > 
> >   ./configure
> > 
> > (2) Use nothing bundled.
> > 
> >   ./configure --disable-bundled
> > 
> > (3) Use everything bundled with some explicit non-bundled stuff.
> > 
> >   ./configure --with-leveldb=/path/to/leveldb/prefix
> > 
> > The other case discussed in the previous review for this was also "Use nothing bundled unless explicitly requested.". That would have looked something like:
> > 
> >   ./configure --disable-bundled --with-bundled-zookeeper
> > 
> > This can still be accomplished by (3), at least after we've added --with-* flags for all bundled dependencies, it'll just be more work/verbose for the end user (because they'll have to specify --with-* for each dependency rather than just specify the bundled dependencies they want to use). I'm happy with this iteration for now since I think (1), (2), and (3) will likely be the most used, I just wanted to confirm that was your plan because that was not resolved in the previous review.

Yup, this is the pattern.   


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20119/#review39943
-----------------------------------------------------------


On April 8, 2014, 2:21 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20119/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 2:21 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-1071 and MESOS-1168
>     https://issues.apache.org/jira/browse/MESOS-1071
>     https://issues.apache.org/jira/browse/MESOS-1168
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Allows preventing the use of bundled libraries in favor of preinstalled versions, where possible.
> 
> --disable-bundled generally switches from bundled to preinstalled libraries.
> 
> If --disable-bundled is supplied or --with-leveldb[=DIR] was given but the configuration phase could not locate the dependency, it stops with an error.
> If --disable-bundled is not supplied and no --with-leveldb[=DIR] was given, the bundled library is built and used (DEFAULT). 
> 
> NOTE: 
> 1. This review only implements this preinstalled library usage on LevelDB & ZooKeeper. Subsequent review requests for other bundled libraries will follow as soon as this implementation has been accepted.
> 
> 2. This modification removed the old --without-installed-PACKAGE semantics, as they conflict with well established --with-PACKAGE semantics
> 
> 
> Diffs
> -----
> 
>   3rdparty/Makefile.am 23ff1fa 
>   configure.ac c1de6d7 
>   src/Makefile.am 95f133d 
>   src/python/setup.py.in 02f00ef 
> 
> Diff: https://reviews.apache.org/r/20119/diff/
> 
> 
> Testing
> -------
> 
> make check across all combinatoric incantations. 
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


--===============7419349824985248324==--