Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 15A2710819 for ; Wed, 9 Apr 2014 02:55:41 +0000 (UTC) Received: (qmail 12230 invoked by uid 500); 9 Apr 2014 02:55:40 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 11925 invoked by uid 500); 9 Apr 2014 02:55:38 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 11905 invoked by uid 99); 9 Apr 2014 02:55:35 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Apr 2014 02:55:35 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4A2BC1D5E21; Wed, 9 Apr 2014 02:55:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7177982334524941739==" MIME-Version: 1.0 Subject: Re: Review Request 20141: Added containerizer.proto. From: "Mesos ReviewBot" To: "Niklas Nielsen" , "Benjamin Hindman" Cc: "Mesos ReviewBot" , "mesos" , "Till Toenshoff" Date: Wed, 09 Apr 2014 02:55:28 -0000 Message-ID: <20140409025528.16004.47244@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/20141/ X-Sender: "Mesos ReviewBot" References: <20140409002539.12752.42739@reviews.apache.org> In-Reply-To: <20140409002539.12752.42739@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos-git --===============7177982334524941739== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20141/#review39859 ----------------------------------------------------------- Patch looks great! Reviews applied: [20141] All tests passed. - Mesos ReviewBot On April 9, 2014, 12:25 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20141/ > ----------------------------------------------------------- > > (Updated April 9, 2014, 12:25 a.m.) > > > Review request for mesos, Benjamin Hindman and Niklas Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Adds containerizer.proto containing protobuf message definitions for "launch" and "update". Both are used in the upcoming External Containerizer. > > These protos are defined within their own namespace: containerizer. > > > Diffs > ----- > > src/Makefile.am 95f133d > src/slave/containerizer/containerizer.proto PRE-CREATION > > Diff: https://reviews.apache.org/r/20141/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > > --===============7177982334524941739==--