Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A8B8511974 for ; Tue, 8 Apr 2014 20:11:17 +0000 (UTC) Received: (qmail 51100 invoked by uid 500); 8 Apr 2014 20:11:15 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 50483 invoked by uid 500); 8 Apr 2014 20:11:14 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 50451 invoked by uid 99); 8 Apr 2014 20:11:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Apr 2014 20:11:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B57521D5DF7; Tue, 8 Apr 2014 20:11:08 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1858972258714893525==" MIME-Version: 1.0 Subject: Re: Review Request 20025: Rename CgroupsLauncher to LinuxLauncher From: "Ian Downes" To: "Benjamin Hindman" , "Vinod Kone" , "Jie Yu" , "Cong Wang" , "Chi Zhang" Cc: "Dominic Hamon" , "mesos" , "Mesos ReviewBot" , "Ian Downes" Date: Tue, 08 Apr 2014 20:11:08 -0000 Message-ID: <20140408201108.16004.10406@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Ian Downes" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/20025/ X-Sender: "Ian Downes" References: <20140404203327.18195.26707@reviews.apache.org> In-Reply-To: <20140404203327.18195.26707@reviews.apache.org> Reply-To: "Ian Downes" X-ReviewRequest-Repository: mesos-git --===============1858972258714893525== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20025/ ----------------------------------------------------------- (Updated April 8, 2014, 8:11 p.m.) Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang. Changes ------- Added tests and rebased. Repository: mesos-git Description ------- This is a rename only; there are no code changes but this facilitates a follow on review which will modify the launcher to support both Linux cgroups and Linux namespaces. Diffs (updated) ----- src/Makefile.am 95f133d0103fdebb6de279a07bbeefbf0355f5af src/slave/containerizer/cgroups_launcher.hpp db61107141f60dd13cfa13278a7daab16f0d108c src/slave/containerizer/cgroups_launcher.cpp 39f0e4c3baaed3403da160ba63dada4a53d9af09 src/slave/containerizer/containerizer.cpp 344872a6485c5b0c2c68ddbe0190e52e99cc0b0c src/tests/isolator_tests.cpp dde977eed7716ee9d9e139607d8f5c06d5ca8e13 Diff: https://reviews.apache.org/r/20025/diff/ Testing ------- make check # Linux Thanks, Ian Downes --===============1858972258714893525==--