Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B99F410805 for ; Tue, 8 Apr 2014 01:05:25 +0000 (UTC) Received: (qmail 41462 invoked by uid 500); 8 Apr 2014 01:05:24 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 41421 invoked by uid 500); 8 Apr 2014 01:05:22 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 41411 invoked by uid 99); 8 Apr 2014 01:05:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Apr 2014 01:05:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B5DC81D5DCB; Tue, 8 Apr 2014 01:05:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2707774224892332461==" MIME-Version: 1.0 Subject: Re: Review Request 19702: Added linux routing library for network isolation. From: "Chi Zhang" To: "Benjamin Hindman" , "Vinod Kone" , "Cong Wang" , "Ian Downes" , "Chi Zhang" Cc: "Jie Yu" , "mesos" Date: Tue, 08 Apr 2014 01:05:12 -0000 Message-ID: <20140408010512.28479.90985@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chi Zhang" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/19702/ X-Sender: "Chi Zhang" References: <20140407182544.13805.13711@reviews.apache.org> In-Reply-To: <20140407182544.13805.13711@reviews.apache.org> Reply-To: "Chi Zhang" X-ReviewRequest-Repository: mesos-git --===============2707774224892332461== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19702/#review39752 ----------------------------------------------------------- src/linux/routing.cpp missing a: rtnl_u32_set_cls_terminal(cls); see 00a3957606c4c6696dedea03c131e0af83958e90 it stops matching following classifiers if the packet is matched at a filter without actions. - Chi Zhang On April 7, 2014, 6:25 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19702/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 6:25 p.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > See summary. It's reviewable. > > > Diffs > ----- > > configure.ac c1de6d7 > src/Makefile.am 95f133d > src/linux/routing.hpp PRE-CREATION > src/linux/routing.cpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/19702/diff/ > > > Testing > ------- > > make check > > sudo make check > > > Thanks, > > Jie Yu > > --===============2707774224892332461==--