Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3D57810885 for ; Thu, 3 Apr 2014 02:51:15 +0000 (UTC) Received: (qmail 4923 invoked by uid 500); 3 Apr 2014 02:51:14 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 4890 invoked by uid 500); 3 Apr 2014 02:51:14 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 4870 invoked by uid 99); 3 Apr 2014 02:51:13 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Apr 2014 02:51:13 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E09F11D5CEF; Thu, 3 Apr 2014 02:51:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5355977422528937659==" MIME-Version: 1.0 Subject: Re: Review Request 19702: Added linux routing library for network isolation. From: "Mesos ReviewBot" To: "Benjamin Hindman" , "Vinod Kone" , "Cong Wang" , "Ian Downes" , "Chi Zhang" Cc: "mesos" , "Jie Yu" , "Mesos ReviewBot" Date: Thu, 03 Apr 2014 02:50:59 -0000 Message-ID: <20140403025059.29484.15937@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/19702/ X-Sender: "Mesos ReviewBot" References: <20140403021523.29484.16269@reviews.apache.org> In-Reply-To: <20140403021523.29484.16269@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos-git --===============5355977422528937659== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19702/#review39389 ----------------------------------------------------------- Patch looks great! Reviews applied: [19981, 19982, 19702] All tests passed. - Mesos ReviewBot On April 3, 2014, 2:15 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19702/ > ----------------------------------------------------------- > > (Updated April 3, 2014, 2:15 a.m.) > > > Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang. > > > Repository: mesos-git > > > Description > ------- > > UPDATE: > > Added impl. (including tests) for managing IP packet filter. > > ------ > > 1) adjusted a few interfaces per review comments. > 2) added impl. (including tests) for managing links. > > I'll be adding impl. for managing filters soon (currently, they return Error("Unimplemented").) > > > ------ > > Hey guys, I send this review in order to get an idea about the interface design. > > Feel free to jump in to express your thoughts, suggestions, concerns, etc. > > Thanks! > > > Diffs > ----- > > configure.ac 5404dc2 > src/Makefile.am 95f133d > src/linux/routing.hpp PRE-CREATION > src/linux/routing.cpp PRE-CREATION > src/tests/routing_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/19702/diff/ > > > Testing > ------- > > make check > > sudo make check > > > Thanks, > > Jie Yu > > --===============5355977422528937659==--