Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1A15310DDB for ; Wed, 2 Apr 2014 21:56:18 +0000 (UTC) Received: (qmail 77753 invoked by uid 500); 2 Apr 2014 21:56:16 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 77704 invoked by uid 500); 2 Apr 2014 21:56:16 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 77691 invoked by uid 99); 2 Apr 2014 21:56:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Apr 2014 21:56:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2557B1D5CD9; Wed, 2 Apr 2014 21:56:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5385810829908710786==" MIME-Version: 1.0 Subject: Re: Review Request 19416: Moved subprocess and cleanup method to new cpp. From: "Benjamin Hindman" To: "Ben Mahler" Cc: "Benjamin Hindman" , "mesos" , "Dominic Hamon" Date: Wed, 02 Apr 2014 21:56:11 -0000 Message-ID: <20140402215611.9496.2168@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Benjamin Hindman" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/19416/ X-Sender: "Benjamin Hindman" References: <20140320225819.10647.94441@reviews.apache.org> In-Reply-To: <20140320225819.10647.94441@reviews.apache.org> Reply-To: "Benjamin Hindman" X-ReviewRequest-Repository: mesos-git --===============5385810829908710786== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19416/#review39363 ----------------------------------------------------------- Ship it! Ship It! - Benjamin Hindman On March 20, 2014, 10:58 p.m., Dominic Hamon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19416/ > ----------------------------------------------------------- > > (Updated March 20, 2014, 10:58 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > see summary > > this is part zero of 19162 which will be rebased to depend on this. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 3c6219eb6e76306463b3710ab7e50ec8b75d3d76 > 3rdparty/libprocess/include/process/subprocess.hpp 75b2a96b3ca62a4a59e64aba046f1d797bd8ebf6 > 3rdparty/libprocess/src/subprocess.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/19416/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Dominic Hamon > > --===============5385810829908710786==--