Return-Path: 
 <dev-return-22013-apmail-mesos-dev-archive=mesos.apache.org@mesos.apache.org>
X-Original-To: apmail-mesos-dev-archive@www.apache.org
Delivered-To: apmail-mesos-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 97E3311838
	for <apmail-mesos-dev-archive@www.apache.org>;
 Wed,  2 Apr 2014 07:29:30 +0000 (UTC)
Received: (qmail 47916 invoked by uid 500); 2 Apr 2014 07:29:29 -0000
Delivered-To: apmail-mesos-dev-archive@mesos.apache.org
Received: (qmail 47068 invoked by uid 500); 2 Apr 2014 07:29:27 -0000
Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@mesos.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@mesos.apache.org>
List-Post: <mailto:dev@mesos.apache.org>
List-Id: <dev.mesos.apache.org>
Reply-To: dev@mesos.apache.org
Delivered-To: mailing list dev@mesos.apache.org
Received: (qmail 45755 invoked by uid 99); 2 Apr 2014 07:29:21 -0000
Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Apr 2014 07:29:21 +0000
Received: from reviews.apache.org (localhost [127.0.0.1])
	by reviews.apache.org (Postfix) with ESMTP id 1042E1C0298;
	Wed,  2 Apr 2014 07:29:17 +0000 (UTC)
Content-Type: multipart/alternative;
 boundary="===============8447000688018415210=="
MIME-Version: 1.0
Subject: Re: Review Request 17567: Added External Containerizer.
From: "Mesos ReviewBot" <dev@mesos.apache.org>
To: "Niklas Nielsen" <nik@qni.dk>, "Vinod Kone" <vinodkone@gmail.com>,
 "Ian Downes" <ian.downes@gmail.com>
Cc: "Adam B" <adam@mesosphere.io>, "mesos" <dev@mesos.apache.org>,
 "Till Toenshoff" <toenshoff@me.com>, "Mesos ReviewBot" <dev@mesos.apache.org>
Date: Wed, 02 Apr 2014 07:29:16 -0000
Message-ID: <20140402072916.16750.30034@reviews.apache.org>
X-ReviewBoard-URL: https://reviews.apache.org
Auto-Submitted: auto-generated
Sender: "Mesos ReviewBot" <noreply@reviews.apache.org>
X-ReviewGroup: mesos
X-ReviewRequest-URL: https://reviews.apache.org/r/17567/
X-Sender: "Mesos ReviewBot" <noreply@reviews.apache.org>
References: <20140402020234.2770.31956@reviews.apache.org>
In-Reply-To: <20140402020234.2770.31956@reviews.apache.org>
Reply-To: "Mesos ReviewBot" <dev@mesos.apache.org>
X-ReviewRequest-Repository: mesos-git

--===============8447000688018415210==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17567/#review39245
-----------------------------------------------------------


Bad patch!

Reviews applied: [19795, 18403, 17567]

Failed command: git apply --index 17567.patch

Error:
 error: patch failed: src/slave/flags.hpp:196
error: src/slave/flags.hpp: patch does not apply


- Mesos ReviewBot


On April 2, 2014, 2:02 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17567/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 2:02 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-816
>     https://issues.apache.org/jira/browse/MESOS-816
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This patch adds the so-called external containerizer. This
> containerizer delegates all containerizer calls directly to 
> an external containerizer program (which can be specified on 
> start-up). Few calls have internal fall-back implementations 
> such as wait(), destroy() and usage().
> 
> The protocol for the interactions with the external program
> is as follows:
> 
> COMMAND (ADDITIONAL-PARAMETERS) < INPUT-PROTO > RESULT-PROTO
> 
> launch (ContainerID, --mesos-executor, <path>) < TaskInfo > ExternalStatus
> update (ContainerID) < ResourceArray > ExternalStatus
> usage (ContainerID) > ResourceStatistics
> wait (ContainerID) > ExternalTermination
> destroy (ContainerID) > ExternalStatus
> 
> When protocol buffers need to be provided, the Mesos side of
> the external containerizer implementation will serialize the 
> protos on stdin and vice-versa for reading protos on stdout as 
> drafted in the above scheme.
> 
> 
> NOTE: This is currently work in progress to cover all comments.
> 
> 
> Diffs
> -----
> 
>   configure.ac 5404dc2 
>   include/mesos/mesos.proto 37f8a7f 
>   src/Makefile.am 0775a0d 
>   src/examples/python/test-containerizer.in PRE-CREATION 
>   src/examples/python/test_containerizer.py PRE-CREATION 
>   src/slave/containerizer/containerizer.cpp 6de091e 
>   src/slave/containerizer/external_containerizer.hpp PRE-CREATION 
>   src/slave/containerizer/external_containerizer.cpp PRE-CREATION 
>   src/slave/flags.hpp c9a627b 
>   src/tests/external_containerizer_test.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17567/diff/
> 
> 
> Testing
> -------
> 
> make check and functional testing.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


--===============8447000688018415210==--