Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D3C4710B00 for ; Tue, 1 Apr 2014 23:18:45 +0000 (UTC) Received: (qmail 49919 invoked by uid 500); 1 Apr 2014 23:18:44 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 49828 invoked by uid 500); 1 Apr 2014 23:18:44 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 49817 invoked by uid 99); 1 Apr 2014 23:18:44 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Apr 2014 23:18:44 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B51C81D5B40; Tue, 1 Apr 2014 23:18:40 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============9208152114122138190==" MIME-Version: 1.0 Subject: Re: Review Request 19761: Added a performance test for registrar which is disabled by default. From: "Vinod Kone" To: "Vinod Kone" , "Ben Mahler" Cc: "Jiang Yan Xu" , "mesos" Date: Tue, 01 Apr 2014 23:18:40 -0000 Message-ID: <20140401231840.2770.32458@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/19761/ X-Sender: "Vinod Kone" References: <20140401011342.2770.57056@reviews.apache.org> In-Reply-To: <20140401011342.2770.57056@reviews.apache.org> Reply-To: "Vinod Kone" X-ReviewRequest-Repository: mesos-git --===============9208152114122138190== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19761/#review39215 ----------------------------------------------------------- src/tests/registrar_tests.cpp Can you actually implement this TODO? Would be good starting point for us to write benchmark tests. - Vinod Kone On April 1, 2014, 1:13 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19761/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 1:13 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/registrar_tests.cpp 67c26aad8185f1328a7eb05c993ed14d47dc0664 > > Diff: https://reviews.apache.org/r/19761/diff/ > > > Testing > ------- > > mesos-tests.sh –verbose –gtest_filter=“RegistrarTest*” –gtest_also_run_disabled_tests > > > Thanks, > > Jiang Yan Xu > > --===============9208152114122138190==--