Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 318AB10AD2 for ; Tue, 1 Apr 2014 02:52:48 +0000 (UTC) Received: (qmail 35851 invoked by uid 500); 1 Apr 2014 02:52:47 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 35675 invoked by uid 500); 1 Apr 2014 02:52:46 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 35664 invoked by uid 99); 1 Apr 2014 02:52:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Apr 2014 02:52:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E2F4C1D5CB1; Tue, 1 Apr 2014 02:52:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0247453153978630423==" MIME-Version: 1.0 Subject: Re: Review Request 19859: Improve javadoc (use @param, @return, etc) From: "Vinod Kone" To: "Tobi Knaup" , "Vinod Kone" , "mesos" Date: Tue, 01 Apr 2014 02:52:41 -0000 Message-ID: <20140401025241.2770.73229@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Vinod Kone" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/19859/ X-Sender: "Vinod Kone" References: <20140401023326.2770.34888@reviews.apache.org> In-Reply-To: <20140401023326.2770.34888@reviews.apache.org> Reply-To: "Vinod Kone" X-ReviewRequest-Repository: mesos-git --===============0247453153978630423== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19859/#review39127 ----------------------------------------------------------- Ship it! i'll commit this once the comment is addressed. src/java/src/org/apache/mesos/Scheduler.java s/the scheduler driver/the driver/ here and everywhere else. src/java/src/org/apache/mesos/state/ZooKeeperState.java thank you. - Vinod Kone On April 1, 2014, 2:33 a.m., Tobi Knaup wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19859/ > ----------------------------------------------------------- > > (Updated April 1, 2014, 2:33 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-135 > https://issues.apache.org/jira/browse/MESOS-135 > > > Repository: mesos-git > > > Description > ------- > > See summary. > There is a separate change in MESOS-570 to publish the docs on mesos.apache.org. > > > Diffs > ----- > > src/java/src/org/apache/mesos/Executor.java 8f4eaee > src/java/src/org/apache/mesos/ExecutorDriver.java cb14f38 > src/java/src/org/apache/mesos/Scheduler.java 55c4706 > src/java/src/org/apache/mesos/SchedulerDriver.java 6bca879 > src/java/src/org/apache/mesos/state/State.java dccb0ff > src/java/src/org/apache/mesos/state/Variable.java bedb74b > src/java/src/org/apache/mesos/state/ZooKeeperState.java f3d939f > > Diff: https://reviews.apache.org/r/19859/diff/ > > > Testing > ------- > > > Thanks, > > Tobi Knaup > > --===============0247453153978630423==--