mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-1181) Improve cpplint rule coverage
Date Wed, 09 Apr 2014 16:40:15 GMT

    [ https://issues.apache.org/jira/browse/MESOS-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964352#comment-13964352
] 

Dominic Hamon commented on MESOS-1181:
--------------------------------------

[~bernd-mesos] Having a macro specifically for cpplint seems fragile and unintuitive. The
correct way to deal with this would be to remove /* implicit */ and add // NOLINT to the end
of the line defining the implicit constructor. This also serves to document where the implicit
constructor is expected.

> Improve cpplint rule coverage
> -----------------------------
>
>                 Key: MESOS-1181
>                 URL: https://issues.apache.org/jira/browse/MESOS-1181
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Adam B
>            Assignee: Adam B
>            Priority: Minor
>              Labels: lint, style
>
> ReviewBot is checking our patches' style for us, and we can check it ourselves with support/mesos-style.py,
but there are only a few rules enabled right now. I plan to enable more rules, fixing lint
errors as needed. I'd also like to add new style rules for things like single/double line
spacing.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message