mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 20750: Support MAVEN_HOME on configure as an environment variable to define the path to the mvn executable.
Date Mon, 28 Apr 2014 18:45:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20750/#review41617
-----------------------------------------------------------


Should we use M2_HOME instead since we are depending on Maven 3.0 or higher for the shaded
plugin?

http://stackoverflow.com/questions/17136324/what-is-the-difference-between-m2-home-and-maven-home

- Vinod Kone


On April 28, 2014, 6:43 p.m., Bernardo Gomez Palacio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20750/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 6:43 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> [MESOS-1252]: Support ENV MAVEN_HOME on the build.
> 
>     The build now supports the `MAVEN_HOME` environment variable which is
>     used to resolve the `mvn` executable. If no `MAVEN_HOME` is specified we
>     will use the one available in the `PATH`.
> 
>     ticket: https://issues.apache.org/jira/browse/MESOS-1252
> 
> 
> Diffs
> -----
> 
>   configure.ac 01182b3 
>   src/Makefile.am c2029c7 
> 
> Diff: https://reviews.apache.org/r/20750/diff/
> 
> 
> Testing
> -------
> 
> Success
> 
> 1. Testing MAVEN_HOME without a `mvn` executable in your path.
> 1.1 Specify MAVEN_HOME=/path/to/your/maven/home `./configure`
> 1.2 Check src/Makefile and validate that the variables MAVEN_HOME and MVN point to the
correct path.
> 1.3 See that `$(MVN)` is used instead of `mvn`.
> 
> 2. With a `mvn` executable in your path.
> 2.1 Do not specify a MAVEN_HOME just make sure you have a `mvn` executable in your path
and call `./configure`
> 2.2 Check src/Makefile and validate that the variables MAVEN_HOME is empty but the MVN
point to the correct executable.
> 2.3 See that `$(MVN)` is used instead of `mvn`.
> 
> 
> Failures
> 2. With a MAVEN_HOME that has a `bin/mvn` executable missing.
> 2.1 Call `MAVEN_HOME=/the/path ./configure`
> 2.2 you should get an error that tells that `mvn` is missing from "/the/path/bin".
> 
> 2. Without a `mvn` executable in your path.
> 2.1 Call `./configure`
> 2.2 you should get an error that tells that `mvn` is missing.
> 
> 
> Thanks,
> 
> Bernardo Gomez Palacio
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message