mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexandra Sava" <alexandrasav...@gmail.com>
Subject Re: Review Request 19357: Add support for all levels of logging through the new minloglevel flag
Date Mon, 28 Apr 2014 07:14:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19357/
-----------------------------------------------------------

(Updated April 28, 2014, 7:14 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Renamed 'minloglevel' flag in 'logging_level' in order to be consistent the existing flags.
Created validation for the 'logging_level' flag in order to notify the user if it entered
an unsupported value.
Updated the documentation for 'logging_level' flag, with the values it can take.
Renamed 'getMinLogLevel' function in 'getLogSeverity' to be more suggestive for what it does.


Bugs: MESOS-1067
    https://issues.apache.org/jira/browse/MESOS-1067


Repository: mesos-git


Description
-------

minloglevel flag is passed as an argument to the command line and it
configures the level of logging to stderr and file. It can take INFO,
WARNING, ERROR or FATAL values. All log messages
at or above the configured log level will be printed.

If 'quiet' flag is also passed to the command line, minloglevel will
affect just the logs from file (if configured by log_dir flag)

If a log directory is present, the log file that will be available for viewing in the browser
will be the one for the minimum log level configured (with or without the presence of minloglevel
flag)
If FATAL is the minimum log level, there is an exception: no log file will
be available in the browser. This is because FATAL logs will cause the program to crash.
So if at any point the user can still access mesos page in the browser, it means no
FATAL logs have been issued.


Diffs (updated)
-----

  src/logging/flags.hpp 457feeeb7ca7ececf3c4e69189800ecb370053e6 
  src/logging/logging.hpp 39c2934f733e5c058f62b5497f31f7a7057bb4c7 
  src/logging/logging.cpp 176e49a6a2aef13be44ff910144c7321c942345a 
  src/master/master.cpp f205dca43f10697862e3fd3f435f1127a9d0aecb 
  src/slave/slave.cpp cb80609ba421b3b9a4664e600f0e53ecab8574c4 
  src/webui/master/static/js/controllers.js 4b8487e0c285f892ad352993c81637f38df1429f 

Diff: https://reviews.apache.org/r/19357/diff/


Testing
-------

1.Test1 - run master and slave with log_dir flag defined and minloglevel flag set to WARNING
        - expected results: - logs at and above WARNING level are logged into log_dir and
stderr
                            - the log file for WARNING logs is accessible in the browser

2.Test2 - run master and slave with log_dir flag defined and minloglevel flag set to FATAL
        - expected results: - logs at FATAL level are logged into log_dir and stderr
                            - no log file is accessible in the browser because as soon as
a FATAL log will be issued, the program will crash

3.Test3 - run master and slave with log_dir flag defined, minloglevel flag set to INFO and
quiet flag defined
        - expected results: - logs at and above INFO level are logged into log_dir and no
logs (just FATAL) are displayed at stderr
                            - the log file for INFO logs is accessible in the browser

4.Test4 - run master and slave with minloglevel flag set to INFO and quiet flag defined
        - expected results: - no logs (just FATAL) are displayed at stderr (quiet flag takes
precedence)
                            - no log file is accessible in the browser

5.Test5 - run master and slave with log_dir and quiet flags defined
        - expected results: - no logs (just FATAL) are displayed at stderr
                            - the log file for INFO logs is accessible in the browse


Thanks,

Alexandra Sava


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message