mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 20496: gprof and gcov coverage
Date Sat, 26 Apr 2014 17:54:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20496/#review41560
-----------------------------------------------------------



configure.ac
<https://reviews.apache.org/r/20496/#comment75034>

    For consistency, use the same format and style is our other --enable-* settings above
(e.g., java, python, optimize).
    
    AS_ARG_ENABLE([gprof],
                  AS_HELP_STRING([--enable-gprof],
                                  [build with support gprof]),
                  [], [enable_gprof=no]) 



configure.ac
<https://reviews.apache.org/r/20496/#comment75035>

    Pull this down to where we do other tests of variables, maybe after "if test "x$enable_optimize"
= "xyes"; then .....".



configure.ac
<https://reviews.apache.org/r/20496/#comment75039>

    Reorder to be consistent with the order above in the test.
    
    Also, what happens when we are using Clang? I'm assuming these flags don't work? If yes,
it would be nice if we can give a configure time error when someone uses clang ad enables
gprof.


- Vinod Kone


On April 18, 2014, 7:02 p.m., mike dupont wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20496/
> -----------------------------------------------------------
> 
> (Updated April 18, 2014, 7:02 p.m.)
> 
> 
> Review request for mesos and mike dupont.
> 
> 
> Bugs: MESOS-1213 and MESOS-987
>     https://issues.apache.org/jira/browse/MESOS-1213
>     https://issues.apache.org/jira/browse/MESOS-987
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The coverage is working
> See the README.md for how to use it.
> 
> 
> Diffs
> -----
> 
>   README.md 8ad18f003c367ea80742edf057180131e6487091 
>   configure.ac c1de6d7eec1fc740c031bebb21a662e654328943 
> 
> Diff: https://reviews.apache.org/r/20496/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> mike dupont
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message