mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 20593: Added method to metrics::Timer to allow timing of async operations.
Date Sat, 26 Apr 2014 00:40:55 GMT


> On April 25, 2014, 9:24 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/include/process/metrics/timer.hpp, line 84
> > <https://reviews.apache.org/r/20593/diff/2/?file=565984#file565984line84>
> >
> >     Alternatively, we could just use the Clock without any additional complexity
and with better testability (no need to sleep, etc) in tests.
> >     
> >     Any reason to prefer Stopwatch? We could move to using Clock::now for start()/stop()
and it would be easier to test that we're correctly timing things.
> 
> Dominic Hamon wrote:
>     I have no preference - i chose the lowest-level abstraction that made sense.
>     
>     You want a change to Clock in this patch?

Storing a 'Time' from Clock::now() would be nice for cleaning up the tests.

Up to you, feel free to just do this in a follow up patch as well.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20593/#review41529
-----------------------------------------------------------


On April 25, 2014, 11:29 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20593/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 11:29 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/metrics/timer.hpp c8e1d91bdc39fb0702bc761e98807abdade4996d

>   3rdparty/libprocess/src/tests/metrics_tests.cpp 294aed424983bbbcaf74c0417c6bcd36a496acb7

> 
> Diff: https://reviews.apache.org/r/20593/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message