mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 20720: Collect Isolator::cleanup() before completing container destroy.
Date Fri, 25 Apr 2014 18:04:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20720/#review41497
-----------------------------------------------------------

Ship it!



src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20720/#comment74939>

    Can you also add a LOG(ERROR) here as you did in ___destroy?
    
    Also, probably say:
    
    "Failed to kill all processes when destroying container..."



src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20720/#comment74940>

    Probably say:
    
    "Failed to cleanup isolators when destroying container... "



src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20720/#comment74941>

    Ditto above.


- Jie Yu


On April 25, 2014, 5:53 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20720/
> -----------------------------------------------------------
> 
> (Updated April 25, 2014, 5:53 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Chi Zhang, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1238
>     https://issues.apache.org/jira/browse/MESOS-1238
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Ensure MesosContainerizer waits for all isolators to complete cleanup before setting
the termination promise. 
> + Container Termination will now fail if cleanup fails rather than silently ignoring
it. 
> + Tests can now wait on containers before destroying a containerizer.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos_containerizer.hpp 99c1354366b3fc99f57773aeb3beece6c6544da2

>   src/slave/containerizer/mesos_containerizer.cpp 722f3fe70c1eae3bd8aa425b3407b6823f23c32a

> 
> Diff: https://reviews.apache.org/r/20720/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message