mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy St. Clair" <tstcl...@redhat.com>
Subject Re: Review Request 20119: Updated policy for building against system dependencies.
Date Fri, 25 Apr 2014 00:53:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20119/
-----------------------------------------------------------

(Updated April 25, 2014, 12:53 a.m.)


Review request for mesos and Benjamin Hindman.


Changes
-------

switch inner test from == -> = 


Bugs: MESOS-1071 and MESOS-1168
    https://issues.apache.org/jira/browse/MESOS-1071
    https://issues.apache.org/jira/browse/MESOS-1168


Repository: mesos-git


Description
-------

Allows preventing the use of bundled libraries in favor of preinstalled versions, where possible.

--disable-bundled generally switches from bundled to preinstalled libraries.

If --disable-bundled is supplied or --with-leveldb[=DIR] was given but the configuration phase
could not locate the dependency, it stops with an error.
If --disable-bundled is not supplied and no --with-leveldb[=DIR] was given, the bundled library
is built and used (DEFAULT). 

NOTE: 
1. This review only implements this preinstalled library usage on LevelDB & ZooKeeper.
Subsequent review requests for other bundled libraries will follow as soon as this implementation
has been accepted.

2. This modification removed the old --without-installed-PACKAGE semantics, as they conflict
with well established --with-PACKAGE semantics


Diffs (updated)
-----

  3rdparty/Makefile.am 23ff1fa 
  configure.ac 570eb4b 
  src/Makefile.am 9716cfd 
  src/python/setup.py.in 02f00ef 

Diff: https://reviews.apache.org/r/20119/diff/


Testing
-------

make check across all combinatoric incantations. 


Thanks,

Timothy St. Clair


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message