mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 20668: Updated containerizer.proto's Launch message, added Destroy-, Wait- and Usage-messages.
Date Thu, 24 Apr 2014 16:53:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20668/#review41325
-----------------------------------------------------------

Ship it!



include/mesos/containerizer/containerizer.proto
<https://reviews.apache.org/r/20668/#comment74750>

    Is it just me or is the comments a bit verbose and repetitive? :)
    
    How about something like,
    
    /* Encodes wait command for external containerizer program */
    
    ?
    
    Containerized wait/destroy/usage doesn't add much context.


- Niklas Nielsen


On April 24, 2014, 9:15 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20668/
> -----------------------------------------------------------
> 
> (Updated April 24, 2014, 9:15 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Updated Launch message to reflect latest commits on the TaskInfo related containerizer
Launch call/s. Renamed the Launch message attribute "mesos_executor_path" to "mesos_libexec_directory"
which will now hold the libexec-path instead of the  mesos-executor path directly - thus being
usable for other mesos provided executables (e.g. mesos-usage).
> 
> Added Destroy, Wait and Usage messages to allow extending those messages in the future,
where needed.
> 
> 
> Diffs
> -----
> 
>   include/mesos/containerizer/containerizer.proto 6ecd82e 
> 
> Diff: https://reviews.apache.org/r/20668/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message