mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 20618: Added a test for testing the base set in log ZooKeeper network.
Date Wed, 23 Apr 2014 18:53:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20618/#review41185
-----------------------------------------------------------

Ship it!



src/tests/log_tests.cpp
<https://reviews.apache.org/r/20618/#comment74605>

    Should this test be inside an ifdef for MESOS_HAS_JAVA since that's how the include is
guarded for ZooKeeperTest?


- Ben Mahler


On April 23, 2014, 6:41 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20618/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 6:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1231
>     https://issues.apache.org/jira/browse/MESOS-1231
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Followup for https://reviews.apache.org/r/20602/
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/log/network.hpp ad9854b 
>   src/tests/log_tests.cpp db91ef8 
> 
> Diff: https://reviews.apache.org/r/20618/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message