mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 20581: Added Metrics to registrar.
Date Wed, 23 Apr 2014 01:10:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20581/#review41104
-----------------------------------------------------------



src/master/registrar.cpp
<https://reviews.apache.org/r/20581/#comment74514>

    Looks like this needs a rebase, but how about introducing an unnamed struct in Registrar
so we can do:
    
    timers.fetch
    timers.store
    
    gauges.queued_operations
    
    Akin to what we did for 'stats' and 'slaves' in Master.


- Ben Mahler


On April 23, 2014, 12:41 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20581/
> -----------------------------------------------------------
> 
> (Updated April 23, 2014, 12:41 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Added Timers for state store/fetch and a Gauge to track the length of the operations
queue.
> 
> 
> Diffs
> -----
> 
>   src/master/registrar.cpp 38040bdb519c7f0562ddfeb58d2809cffa6f4c18 
> 
> Diff: https://reviews.apache.org/r/20581/diff/
> 
> 
> Testing
> -------
> 
> local build + mesos-local.sh + manual inspection.
> make check.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message