mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 20297: Added API for managing IP packet filters.
Date Fri, 18 Apr 2014 21:29:55 GMT


> On April 15, 2014, 7:05 p.m., Cong Wang wrote:
> > src/linux/routing/filter/ip.cpp, line 245
> > <https://reviews.apache.org/r/20297/diff/1/?file=555709#file555709line245>
> >
> >     i <= 0xff is always true since i is an unsigned char. Picking a reasonable
number here, for example 64, is okay. It's unlikely that anyone will use more than 64 keys
in one filter.

It's OK. We won't iterate that number of time (given there is a 'break').


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20297/#review40435
-----------------------------------------------------------


On April 13, 2014, 11:50 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20297/
> -----------------------------------------------------------
> 
> (Updated April 13, 2014, 11:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong
Wang.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The is Part 4 of the linux routing library.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 560b4c7 
>   src/linux/routing/filter/ip.hpp PRE-CREATION 
>   src/linux/routing/filter/ip.cpp PRE-CREATION 
>   src/tests/routing_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20297/diff/
> 
> 
> Testing
> -------
> 
> make check
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message