mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 20015: Added history to metrics library.
Date Fri, 18 Apr 2014 18:32:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20015/#review40794
-----------------------------------------------------------

Ship it!


Great stuff! Thanks Dominic!

- Ben Mahler


On April 18, 2014, 2:27 a.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20015/
> -----------------------------------------------------------
> 
> (Updated April 18, 2014, 2:27 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-1036
>     https://issues.apache.org/jira/browse/MESOS-1036
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/metrics/counter.hpp f4774ada4dbe3fa18b5a8b204f97f59ca015b3c1

>   3rdparty/libprocess/include/process/metrics/gauge.hpp 4f5c1086ac3553319431283165c5451df1a0ee3f

>   3rdparty/libprocess/include/process/metrics/metric.hpp ea64f699fd9ec38745d84c7523133709827f96db

>   3rdparty/libprocess/src/tests/metrics_tests.cpp 0cc9f4bcbbb03ac3a9a2d57f64b944443fcb94bb

> 
> Diff: https://reviews.apache.org/r/20015/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message