mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 18600: Allowed replicated log to do auto initialization.
Date Fri, 18 Apr 2014 00:46:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18600/#review40724
-----------------------------------------------------------



src/log/recover.cpp
<https://reviews.apache.org/r/18600/#comment73860>

    How about s/Running r/R/ and s/Retry/Retrying/ ?
    
    Would it be possible to have the timeout duration in this log message?



src/log/recover.cpp
<https://reviews.apache.org/r/18600/#comment73861>

    10 Seconds seems like quite a lot when we expect operators to start replicas sequentially?
What would be the consequences of a lower timeout?



src/log/recover.cpp
<https://reviews.apache.org/r/18600/#comment73864>

    Maybe a good TODO would be on the Log interface? I'm curious why we would allow the 'quorum'
to be specified explicitly when constructing a Log with a set of pids. Are there reasons for
having larger than necessary quorum sizes?
    
    We don't seem to be validating the quorum size is large enough w.r.t 'pids'?



src/log/recover.cpp
<https://reviews.apache.org/r/18600/#comment73863>

    Do we want to chain this new run behind 'future' transitioning from pending or is it safe
to proceed immediately with the new protocol run?



src/tests/log_tests.cpp
<https://reviews.apache.org/r/18600/#comment73858>

    We have macros to do this in one line if you like:
    
    AWAIT_EQ
    AWAIT_ASSERT_EQ
    AWAIT_EXPECT_EQ
    
    Ditto elsewhere.


- Ben Mahler


On April 16, 2014, 11:43 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18600/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 11:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-984
>     https://issues.apache.org/jira/browse/MESOS-984
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/log/log.hpp 6787c80 
>   src/log/log.cpp 9dd992f 
>   src/log/recover.hpp 634bc06 
>   src/log/recover.cpp 688da5f 
>   src/tests/log_tests.cpp 4f08927 
> 
> Diff: https://reviews.apache.org/r/18600/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message