mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tobi Knaup" <t...@knaup.me>
Subject Re: Review Request 20402: Use maven to compile and package Mesos' Java files
Date Wed, 16 Apr 2014 18:00:57 GMT


> On April 16, 2014, 5:22 a.m., John Sirois wrote:
> > src/Makefile.am, line 603
> > <https://reviews.apache.org/r/20402/diff/1/?file=560751#file560751line603>
> >
> >     should this `... clean package` to kill dead classfiles when protobuf messages
go away?  LHS did this afaict with its `rm -rf ...`

Good catch, thanks!


- Tobi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20402/#review40501
-----------------------------------------------------------


On April 16, 2014, 4:24 p.m., Tobi Knaup wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20402/
> -----------------------------------------------------------
> 
> (Updated April 16, 2014, 4:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Patrick Wendell.
> 
> 
> Bugs: MESOS-1212
>     https://issues.apache.org/jira/browse/MESOS-1212
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Use Maven to build the Mesos jars, and include shaded protbuf jar.
> No longer builds a custom protobuf jar but relies on Maven.
> 
> NOTE: #20329 (shading) is a breaking change for JVM frameworks which use the com.google.protobuf
namespace. These need to change to org.apache.mesos.com.google.protobuf.
> 
> Includes the dependent patch from https://reviews.apache.org/r/20329/ which I'll delete
once that's merged.
> 
> 
> Diffs
> -----
> 
>   configure.ac c1de6d7 
>   src/Makefile.am 560b4c7 
>   src/examples/java/TestExceptionFramework.java 464b3b0 
>   src/examples/java/TestFramework.java 65ee2dc 
>   src/examples/java/TestMultipleExecutorsFramework.java 6846959 
>   src/examples/java/test-exception-framework.in 26617e2 
>   src/examples/java/test-executor.in 8b27a37 
>   src/examples/java/test-framework.in bbdc1ed 
>   src/examples/java/test-log.in b7e69e4 
>   src/examples/java/test-multiple-executors-framework.in eb8edf6 
>   src/java/mesos.pom.in 8f9b747 
> 
> Diff: https://reviews.apache.org/r/20402/diff/
> 
> 
> Testing
> -------
> 
> make check
> make maven-install
> 
> 
> Thanks,
> 
> Tobi Knaup
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message