mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 19487: Change linkage around libjvm to use dlopen.
Date Mon, 14 Apr 2014 17:19:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19487/#review40273
-----------------------------------------------------------



configure.ac
<https://reviews.apache.org/r/19487/#comment73236>

    Given these changes, I feel like taking JAVA_LDFLAGS is misleading since we're not actually
linking libjvm into anything (IIUC). In fact, I'd even prefer to simplify our configure tests
to just compile (is there any advantage in checking that we can link?).



src/jvm/jvm.cpp
<https://reviews.apache.org/r/19487/#comment73237>

    We put headers in alphabetical order (after being ordered by what could/should be installed
before what's local), so please move this above the '#include "jvm/jvm.hpp"'.



src/jvm/jvm.cpp
<https://reviews.apache.org/r/19487/#comment73238>

    s/void * hdl/void* handle/ please.



src/jvm/jvm.cpp
<https://reviews.apache.org/r/19487/#comment73239>

    Can we please move the typedef down here where it's used to keep it local?



src/jvm/jvm.cpp
<https://reviews.apache.org/r/19487/#comment73240>

    Wow, that is so cool that this is all it takes to separate us from linking in libjvm!!!


- Benjamin Hindman


On April 11, 2014, 8:28 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19487/
> -----------------------------------------------------------
> 
> (Updated April 11, 2014, 8:28 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-1126
>     https://issues.apache.org/jira/browse/MESOS-1126
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> The dependency on libjvm is a "hard", requiring an link and rpath. This causes issues
when shifting between jvms. The standard practice is to use dlopen against the $JAVA_JVM_LIBRARY
location.
> 
> MESOS-1126
>     + Enable dlopen for libjvm.so
>     + Cleanup redundant jni inclusions
> 
> This should make MESOS-855 a non-issue.
> 
> 
> Diffs
> -----
> 
>   configure.ac c1de6d7 
>   src/Makefile.am 95f133d 
>   src/common/build.hpp 115e9cc 
>   src/common/build.cpp eed08ed 
>   src/jvm/jvm.cpp d3dfa75 
> 
> Diff: https://reviews.apache.org/r/19487/diff/
> 
> 
> Testing
> -------
> 
> make check (across both Mac and Linux)
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message