mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy St. Clair" <tstcl...@redhat.com>
Subject Re: Review Request 19487: Change linkage around libjvm to use dlopen.
Date Fri, 11 Apr 2014 20:02:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19487/
-----------------------------------------------------------

(Updated April 11, 2014, 8:02 p.m.)


Review request for mesos, Benjamin Hindman, Niklas Nielsen, and Till Toenshoff.


Changes
-------

Updated patch per review


Bugs: MESOS-1126
    https://issues.apache.org/jira/browse/MESOS-1126


Repository: mesos-git


Description
-------

The dependency on libjvm is a "hard", requiring an link and rpath. This causes issues when
shifting between jvms. The standard practice is to use dlopen against the $JAVA_JVM_LIBRARY
location.

MESOS-1126
    + Enable dlopen for libjvm.so
    + Cleanup redundant jni inclusions

This should make MESOS-855 a non-issue.


Diffs (updated)
-----

  configure.ac c1de6d7 
  src/Makefile.am 95f133d 
  src/common/build.hpp 115e9cc 
  src/common/build.cpp eed08ed 
  src/jvm/jvm.cpp d3dfa75 

Diff: https://reviews.apache.org/r/19487/diff/


Testing
-------

make check (across both Mac and Linux)


Thanks,

Timothy St. Clair


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message