mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 20026: Support optional container set up commands and Linux namespaces.
Date Wed, 09 Apr 2014 23:28:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20026/#review39963
-----------------------------------------------------------


This review looks like it could really use a split, one for the api change and one for clone?

- Vinod Kone


On April 8, 2014, 8:37 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20026/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 8:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Modified Isolator API so optional commands are returned from prepare and run in the child
before exec'ing the executor.
> 
> Modified LinuxLauncher to use clone() to optionally run a process in one or more different
namespaces.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolator.hpp d410c73c5feac9cbd391b7a2b66141aa9aa75423 
>   src/slave/containerizer/isolator.cpp f7935b3f20530e9c5558a636f40d69371a963102 
>   src/slave/containerizer/isolators/cgroups/cpushare.hpp 49cc5bc2407e99c81e0a8eaff11cffd1136b019c

>   src/slave/containerizer/isolators/cgroups/cpushare.cpp 11665dbe88e3920fd9d8a2259987611d49e85462

>   src/slave/containerizer/isolators/cgroups/mem.hpp ffd81b330202ad6eff48940b762e3f7105008b4b

>   src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56

>   src/slave/containerizer/isolators/posix.hpp 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524

>   src/slave/containerizer/launcher.hpp dee526f254d56a7a974a70522cd0ca059814fb6d 
>   src/slave/containerizer/launcher.cpp c83327b2f13f0511c8e4e0e9902bc6a1e1328283 
>   src/slave/containerizer/linux_launcher.hpp 8f96c6996e0d06c37c29233f5e02f002db743dfb

>   src/slave/containerizer/linux_launcher.cpp 530e0bd64d71bad761a2eab3d6e2f2179a167b4b

>   src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00

>   src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7

>   src/tests/containerizer_tests.cpp b539070e3f76bb878bd3aeb04da93f25bdcecbeb 
>   src/tests/isolator.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/20026/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message