mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ritwik Yadav" <ritwik.ya...@gmail.com>
Subject Re: Review Request 20106: Added support for flattening from Try and Result objects into Future objects as suggested in the issue MESOS-1160.
Date Wed, 09 Apr 2014 12:05:31 GMT


> On April 9, 2014, 11:42 a.m., Ritwik Yadav wrote:
> > Ship It!

I am sorry for this message. I haven't used Review Board before and I thought "Ship It!" message
was analogous to "LGTM" and if I clicked on the "Ship It!" button it would push the changes.
Apparently, it only generates a message in the thread and the onus of actually shipping the
code is on the reviewer. I guess the only thing required of me now is to "Close" this thread
by marking it "Submitted". Please do correct me if I have figured it out wrong.

Thank you for your time Ben.


- Ritwik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20106/#review39876
-----------------------------------------------------------


On April 8, 2014, 10:09 p.m., Ritwik Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20106/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 10:09 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1160
>     https://issues.apache.org/jira/browse/MESOS-1160
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Support flattening from Try,Result into Future.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 37c04c3 
>   3rdparty/libprocess/src/tests/process_tests.cpp 9dae931 
> 
> Diff: https://reviews.apache.org/r/20106/diff/
> 
> 
> Testing
> -------
> 
> Ran all tests with suggested changes to slave.cpp
> None of the tests failed.
> 
> 
> Thanks,
> 
> Ritwik Yadav
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message