mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ritwik Yadav" <ritwik.ya...@gmail.com>
Subject Re: Review Request 20106: Added support for flattening from Try and Result objects into Future objects as suggested in the issue MESOS-1160.
Date Tue, 08 Apr 2014 22:09:26 GMT


> On April 7, 2014, 11:23 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/include/process/future.hpp, lines 89-90
> > <https://reviews.apache.org/r/20106/diff/1/?file=552187#file552187line89>
> >
> >     Let's avoid doing Result<T> for now since supporting an implicit constructor
requires template specialization for Future.
> >     
> >     Sound good?
> 
> Benjamin Hindman wrote:
>     +1!

I have left out the flattening for Result<T> for now. However, I was wondering if making
a specialized constructor using the std::enable_if construct would be a good idea?


- Ritwik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20106/#review39742
-----------------------------------------------------------


On April 8, 2014, 10:09 p.m., Ritwik Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20106/
> -----------------------------------------------------------
> 
> (Updated April 8, 2014, 10:09 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1160
>     https://issues.apache.org/jira/browse/MESOS-1160
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Support flattening from Try,Result into Future.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/future.hpp 37c04c3 
>   3rdparty/libprocess/src/tests/process_tests.cpp 9dae931 
> 
> Diff: https://reviews.apache.org/r/20106/diff/
> 
> 
> Testing
> -------
> 
> Ran all tests with suggested changes to slave.cpp
> None of the tests failed.
> 
> 
> Thanks,
> 
> Ritwik Yadav
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message