mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chi Zhang" <chzhc...@gmail.com>
Subject Re: Review Request 19702: Added linux routing library for network isolation.
Date Tue, 08 Apr 2014 01:05:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19702/#review39752
-----------------------------------------------------------



src/linux/routing.cpp
<https://reviews.apache.org/r/19702/#comment72363>

    missing a:
    rtnl_u32_set_cls_terminal(cls);
    
    see 00a3957606c4c6696dedea03c131e0af83958e90
    
    it stops matching following classifiers if the packet is matched at a filter without actions.
    


- Chi Zhang


On April 7, 2014, 6:25 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19702/
> -----------------------------------------------------------
> 
> (Updated April 7, 2014, 6:25 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong
Wang.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary. It's reviewable.
> 
> 
> Diffs
> -----
> 
>   configure.ac c1de6d7 
>   src/Makefile.am 95f133d 
>   src/linux/routing.hpp PRE-CREATION 
>   src/linux/routing.cpp PRE-CREATION 
>   src/tests/routing_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19702/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message