mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 20072: Better error message for protobuf::write.
Date Mon, 07 Apr 2014 18:19:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20072/#review39712
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp
<https://reviews.apache.org/r/20072/#comment72315>

    Looks like this method will return a comma separated list of required values.
    
    So maybe: "The following fields are required but are not initialized: " + message.InitializationErrorString();


- Ben Mahler


On April 7, 2014, 1:58 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20072/
> -----------------------------------------------------------
> 
> (Updated April 7, 2014, 1:58 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Till Toenshoff, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 36b7f1aff943b3072f4c304a31e43e8fb4a8f5f7

> 
> Diff: https://reviews.apache.org/r/20072/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message