mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy St. Clair" <tstcl...@redhat.com>
Subject Re: Review Request 19487: Change linkage around libjvm to use dlopen.
Date Mon, 07 Apr 2014 14:02:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19487/
-----------------------------------------------------------

(Updated April 7, 2014, 2:02 p.m.)


Review request for mesos, Benjamin Hindman, Till Toenshoff, and Vinod Kone.


Changes
-------

Update from code review


Bugs: MESOS-1126
    https://issues.apache.org/jira/browse/MESOS-1126


Repository: mesos-git


Description
-------

The dependency on libjvm is a "hard", requiring an link and rpath. This causes issues when
shifting between jvms. The standard practice is to use dlopen against the $JAVA_JVM_LIBRARY
location.

MESOS-1126
    + Enable dlopen for libjvm.so
    + Cleanup redundant jni inclusions

This should make MESOS-855 a non-issue.


Diffs (updated)
-----

  configure.ac c1de6d7 
  src/Makefile.am 95f133d 
  src/java/jni/construct.cpp 0d0207f 
  src/java/jni/convert.cpp 9f99031 
  src/java/jni/org_apache_mesos_Log.cpp 0548913 
  src/java/jni/org_apache_mesos_state_AbstractState.cpp 476bb27 
  src/java/jni/org_apache_mesos_state_LevelDBState.cpp 30f6309 
  src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp c40e685 
  src/jvm/jvm.cpp d3dfa75 

Diff: https://reviews.apache.org/r/19487/diff/


Testing
-------

make check (across both Mac and Linux)


Thanks,

Timothy St. Clair


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message