mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 19259: Added ability to process::subprocess to run function within child context
Date Thu, 03 Apr 2014 19:32:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19259/#review37440
-----------------------------------------------------------



3rdparty/libprocess/include/process/subprocess.hpp
<https://reviews.apache.org/r/19259/#comment68972>

    It just feels a little restrictive, in that I might want to pass arguments.



3rdparty/libprocess/src/subprocess.cpp
<https://reviews.apache.org/r/19259/#comment71851>

    Change Envp to take an Option<map> and skip the loop over the passed in map if it's
None()?



3rdparty/libprocess/src/subprocess.cpp
<https://reviews.apache.org/r/19259/#comment71852>

    this isn't 'setup && command' as documented. If it was, we wouldn't run command
if setup returned non-zero.


- Dominic Hamon


On April 3, 2014, 12:23 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19259/
> -----------------------------------------------------------
> 
> (Updated April 3, 2014, 12:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Dominic Hamon, and Ian Downes.
> 
> 
> Bugs: MESOS-1102
>     https://issues.apache.org/jira/browse/MESOS-1102
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Adds the ability to process::subprocess to run a function (lambda) within the child context,
after fork and before exec.
> 
> NOTE: Such lambda must not contain any async unsafe code. For details on async safety,
see POSIX.1-2004 on async-signal-safe functions, also referenced in the signal man-pages:
http://man7.org/linux/man-pages/man7/signal.7.html.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 6c51c0b 
>   3rdparty/libprocess/src/subprocess.cpp e09c808 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 9413ecc 
> 
> Diff: https://reviews.apache.org/r/19259/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message