mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 19988: Enabled readability/todo rule for cpplint.
Date Thu, 03 Apr 2014 16:44:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19988/#review39420
-----------------------------------------------------------


Patch looks great!

Reviews applied: [19775, 19988]

All tests passed.

- Mesos ReviewBot


On April 3, 2014, 6:26 a.m., Adam B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19988/
> -----------------------------------------------------------
> 
> (Updated April 3, 2014, 6:26 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-1181
>     https://issues.apache.org/jira/browse/MESOS-1181
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Enabled readability/todo rule for cpplint, which covers the following:
> 'Missing username in TODO; it should look like "// TODO(my_username): Stuff."'
> 
> Used git blame to trace back the unaccredited TODOs, 3 to benh and 2 to bmahler.
> bmahler's TODO in slave.cpp is already covered by one in messages.proto for ReregisterSlaveMessage,
so I removed it.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/decoder.hpp 88da57f 
>   src/exec/exec.cpp 346e39f 
>   src/master/master.cpp 3c3c989 
>   src/sched/sched.cpp 3684cfe 
>   src/slave/slave.cpp a356f5f 
>   support/mesos-style.py edd41f926d6df30513f8fa6c928960e6495af70a 
> 
> Diff: https://reviews.apache.org/r/19988/diff/
> 
> 
> Testing
> -------
> 
> Ran mesos-style.py over entire source base with readability/todo enabled.
> 
> 
> Thanks,
> 
> Adam B
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message