mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <...@mesos.apache.org>
Subject Re: Review Request 19901: Added Termination protobuf message.
Date Wed, 02 Apr 2014 06:25:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19901/#review39237
-----------------------------------------------------------


Patch looks great!

Reviews applied: [19901]

All tests passed.

- Mesos ReviewBot


On April 2, 2014, 5:20 a.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19901/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 5:20 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Niklas Nielsen, and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Replaced slave::Containerizer::Termination with a protobuf message called Termination
for allowing it to be reused in ExternalContainerizer, gaining a serializable Termination
message.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 37f8a7f 
>   src/slave/containerizer/containerizer.hpp d9ae326 
>   src/slave/containerizer/mesos_containerizer.hpp ee1fd30 
>   src/slave/containerizer/mesos_containerizer.cpp c819c97 
>   src/slave/slave.hpp 15e23ce 
>   src/slave/slave.cpp a356f5f 
>   src/tests/containerizer.hpp a9f1531 
>   src/tests/containerizer.cpp bfb9341 
> 
> Diff: https://reviews.apache.org/r/19901/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message