mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 19006: Moved slave disconnection code out of Master::exited() into new disconnect(Slave).
Date Wed, 02 Apr 2014 01:30:44 GMT


> On April 2, 2014, 1:29 a.m., Benjamin Hindman wrote:
> > Ship It!

This change is independent of the naming in 'Slaves', so let's get it committed and follow
up with another review. Thanks Adam.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19006/#review39227
-----------------------------------------------------------


On March 27, 2014, 4:41 a.m., Adam B wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19006/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 4:41 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-804
>     https://issues.apache.org/jira/browse/MESOS-804
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Moved code to disconnect a checkpointing slave out of Master::exited() and into a new
disconnect(Slave), to be re-used by slave authentication code.
> Also renamed deactivateSlave() to shutdownSlave(), since it actually sends a ShutdownMessage
and calls removeSlave(). This avoids confusion with deactivateFramework, which is more analagous
to disconnect(Slave).
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp b6b9983 
>   src/master/master.cpp 5d0ddb0 
> 
> Diff: https://reviews.apache.org/r/19006/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Adam B
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message