mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 19762: Improved Registrar performance by using a hashset on SlaveIDs.
Date Tue, 01 Apr 2014 22:17:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19762/#review39185
-----------------------------------------------------------



src/master/registrar.cpp
<https://reviews.apache.org/r/19762/#comment71561>

    s/;/./



src/master/registrar.cpp
<https://reviews.apache.org/r/19762/#comment71543>

    s/hashset/hashset of SlaveIDs/


- Vinod Kone


On April 1, 2014, 1:13 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19762/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 1:13 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-1155
>     https://issues.apache.org/jira/browse/MESOS-1155
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp eb8cd73e9e8f26a7438070ca2bb078bd2d1ec480 
>   src/master/registrar.hpp 0d659c57d55f7d054e106477c814d921479e3177 
>   src/master/registrar.cpp 9c0537d86036dec3e6a0fac84e167d9131242e0c 
> 
> Diff: https://reviews.apache.org/r/19762/diff/
> 
> 
> Testing
> -------
> 
> mesos-tests.sh –verbose –gtest_filter=“RegistrarTest*” –gtest_also_run_disabled_tests
> On test machines this reduces the time for applying 20,000 (re)admit operations from
30secs to < 100ms
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message