mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 19854: Enable automake 1.14
Date Tue, 01 Apr 2014 20:50:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19854/#review39201
-----------------------------------------------------------

Ship it!


Thanks for the clean up Tim! I'd like a little bit more explicitness in the 'subdir-objects'
comment and then I'll get this committed.


src/Makefile.am
<https://reviews.apache.org/r/19854/#comment71560>

    I suggested pulling out the offending translation units so that people could have some
context to understand what you mean by this comment. Maybe I'm just the ignorant one, but
I'd like this comment to be even more explicit. Here is another suggestion: 
    
    ----
    As of automake 1.14 the 'subdir-objects' option is turned on by default and so we can't
have the same file names in sub-directories because the resulting object files collide (...
how do the relative paths play a role here?). For example, we can't have both a master/constants.cpp
and a slave/constants.cpp.
    ----
    
    Also, is this fixable? Can we add a TODO and include suggestions to fix this so that someone
else doesn't need to try and think of those suggestions themselves in the future?


- Benjamin Hindman


On April 1, 2014, 5:24 p.m., Timothy St. Clair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19854/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 5:24 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-577
>     https://issues.apache.org/jira/browse/MESOS-577
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Enable automake 1.14
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac 2e0b72c 
>   bootstrap ed0bc36 
>   configure.ac 5404dc2 
>   src/Makefile.am 47d03b3 
>   src/master/constants.cpp 1cb8f22 
>   src/master/http.cpp 72d8e91 
>   src/master/master_constants.cpp PRE-CREATION 
>   src/master/master_http.cpp PRE-CREATION 
>   src/slave/constants.cpp 9811bd3 
>   src/slave/http.cpp 594032d 
>   src/slave/slave_constants.cpp PRE-CREATION 
>   src/slave/slave_http.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19854/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy St. Clair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message