mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tobi Knaup" <t...@knaup.me>
Subject Re: Review Request 19859: Improve javadoc (use @param, @return, etc)
Date Tue, 01 Apr 2014 02:34:55 GMT


> On April 1, 2014, 2:25 a.m., John Sirois wrote:
> > src/java/src/org/apache/mesos/ExecutorDriver.java, line 36
> > <https://reviews.apache.org/r/19859/diff/1/?file=543109#file543109line36>
> >
> >     Drive by review - you already get return type linking so @see Status either
seems redundant or its placing extra emphasis on the return type - kill throughout?

I successfully copied an anti-pattern. Killed!


- Tobi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19859/#review39124
-----------------------------------------------------------


On April 1, 2014, 2:33 a.m., Tobi Knaup wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19859/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 2:33 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-135
>     https://issues.apache.org/jira/browse/MESOS-135
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> There is a separate change in MESOS-570 to publish the docs on mesos.apache.org.
> 
> 
> Diffs
> -----
> 
>   src/java/src/org/apache/mesos/Executor.java 8f4eaee 
>   src/java/src/org/apache/mesos/ExecutorDriver.java cb14f38 
>   src/java/src/org/apache/mesos/Scheduler.java 55c4706 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 6bca879 
>   src/java/src/org/apache/mesos/state/State.java dccb0ff 
>   src/java/src/org/apache/mesos/state/Variable.java bedb74b 
>   src/java/src/org/apache/mesos/state/ZooKeeperState.java f3d939f 
> 
> Diff: https://reviews.apache.org/r/19859/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tobi Knaup
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message