Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1FE30CFA6 for ; Mon, 17 Mar 2014 17:29:05 +0000 (UTC) Received: (qmail 43720 invoked by uid 500); 17 Mar 2014 17:29:03 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 43683 invoked by uid 500); 17 Mar 2014 17:29:03 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 43672 invoked by uid 99); 17 Mar 2014 17:29:02 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Mar 2014 17:29:02 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B0A311C32D5; Mon, 17 Mar 2014 17:28:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3207684988558338257==" MIME-Version: 1.0 Subject: Re: Review Request 19299: TRy cleanup in Mesos From: "Jiang Yan Xu" To: "Jiang Yan Xu" , "Jie Yu" , "mesos" , "Archana kumari" Date: Mon, 17 Mar 2014 17:28:59 -0000 Message-ID: <20140317172859.17328.1756@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jiang Yan Xu" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/19299/ X-Sender: "Jiang Yan Xu" References: <20140317172241.17334.28461@reviews.apache.org> In-Reply-To: <20140317172241.17334.28461@reviews.apache.org> Reply-To: "Jiang Yan Xu" X-ReviewRequest-Repository: mesos-git --===============3207684988558338257== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On March 17, 2014, 10:22 a.m., Jie Yu wrote: > > src/master/detector.cpp, line 116 > > > > > > Instead of breaking a string into two lines, I would suggest the following: > > > > return Error( > > "Expecting a (chroot) path for ZooKeeper ('/' is not supported)"); Sure. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19299/#review37406 ----------------------------------------------------------- On March 17, 2014, 10:12 a.m., Archana kumari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19299/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 10:12 a.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Try cleanup in Mesos > > > Diffs > ----- > > src/master/detector.cpp 3a8aaed > > Diff: https://reviews.apache.org/r/19299/diff/ > > > Testing > ------- > > > Thanks, > > Archana kumari > > --===============3207684988558338257==--