Return-Path: X-Original-To: apmail-mesos-dev-archive@www.apache.org Delivered-To: apmail-mesos-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9E55010D7A for ; Tue, 4 Mar 2014 02:25:06 +0000 (UTC) Received: (qmail 60808 invoked by uid 500); 4 Mar 2014 02:25:05 -0000 Delivered-To: apmail-mesos-dev-archive@mesos.apache.org Received: (qmail 60754 invoked by uid 500); 4 Mar 2014 02:25:05 -0000 Mailing-List: contact dev-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list dev@mesos.apache.org Received: (qmail 60736 invoked by uid 99); 4 Mar 2014 02:25:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Mar 2014 02:25:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DBC301D4B5C; Tue, 4 Mar 2014 02:25:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1950733579238751318==" MIME-Version: 1.0 Subject: Re: Review Request 17567: Pluggable Containerizer From: "Niklas Nielsen" To: "Adam B" , "Benjamin Hindman" , "Vinod Kone" , "Niklas Nielsen" , "Ben Mahler" , "Ian Downes" Cc: "mesos" , "Till Toenshoff" Date: Tue, 04 Mar 2014 02:25:03 -0000 Message-ID: <20140304022503.10089.55322@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Niklas Nielsen" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/17567/ X-Sender: "Niklas Nielsen" References: <20140228012356.9913.42636@reviews.apache.org> In-Reply-To: <20140228012356.9913.42636@reviews.apache.org> Reply-To: "Niklas Nielsen" X-ReviewRequest-Repository: mesos-git --===============1950733579238751318== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17567/#review36075 ----------------------------------------------------------- src/examples/python/test_containerizer.py How about making this implementation optional/configurable? We should eventually be exercising both call paths :) Maybe not now, but in a sequent review. src/slave/containerizer/pluggable_containerizer.hpp Think this comment is obsolete ;) src/slave/containerizer/pluggable_containerizer.hpp s/executor/container/? I know the lines are a bit blurry here. src/slave/containerizer/pluggable_containerizer.hpp s/external/pluggable/ and the rest of the review? Just want to get the terms straight :) src/slave/containerizer/pluggable_containerizer.hpp Can you wrap input to next line? src/slave/containerizer/pluggable_containerizer.hpp s/commandSupported/isCommandSupported/? You are using 'get' in getStatus() and getResult() src/slave/containerizer/pluggable_containerizer.cpp You are using 2 indents in wrapping from .onAny(.. to next line in the rest of the file src/slave/containerizer/pluggable_containerizer.cpp 2 indents. src/slave/containerizer/pluggable_containerizer.cpp The wrapping looks odd - I might be wrong. src/slave/containerizer/pluggable_containerizer.cpp s/pogram/program/ src/slave/containerizer/pluggable_containerizer.cpp Kill newline src/slave/containerizer/pluggable_containerizer.cpp s/External/Pluggable/? src/tests/pluggable_containerizer_test.cpp I think this comment is obsolete. - Niklas Nielsen On Feb. 27, 2014, 5:23 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17567/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 5:23 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Ian Downes, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-816 > https://issues.apache.org/jira/browse/MESOS-816 > > > Repository: mesos-git > > > Description > ------- > > This patch adds the so-called pluggable containerizer. This > containerizer delegates all containerizer calls directly to > an external containerizer program (which can be specified on > start-up). Few calls have internal fall-back implementations > such as wait(), destroy() and usage(). > > The protocol for the interactions with the external program > is as follows: > > COMMAND (ADDITIONAL-PARAMETERS) < INPUT-PROTO > RESULT-PROTO > > launch (ContainerID, --mesos-executor, ) < TaskInfo > PluggableStatus > update (ContainerID) < ResourceArray > PluggableStatus > usage (ContainerID) > ResourceStatistics > wait (ContainerID) > PluggableTermination > destroy (ContainerID) > PluggableStatus > > When protocol buffers need to be provided, the Mesos side of > the pluggable containerizer will serialize the protos on stdin > and vice-versa for reading protos on stdout as drafted in the > above scheme. > > > Diffs > ----- > > configure.ac a8bc8a8 > include/mesos/mesos.proto 37f8a7f > src/Makefile.am 61d832b > src/examples/python/test-containerizer.in PRE-CREATION > src/examples/python/test_containerizer.py PRE-CREATION > src/slave/containerizer/containerizer.cpp d0a1023 > src/slave/containerizer/pluggable_containerizer.hpp PRE-CREATION > src/slave/containerizer/pluggable_containerizer.cpp PRE-CREATION > src/slave/flags.hpp e4d98a5 > src/tests/pluggable_containerizer_test.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/17567/diff/ > > > Testing > ------- > > make check and functional testing. > > > Thanks, > > Till Toenshoff > > --===============1950733579238751318==--