mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 19090: Enhanced DRF by including past allocations.
Date Fri, 28 Mar 2014 22:17:03 GMT


> On March 14, 2014, 8:15 p.m., Ben Mahler wrote:
> > src/master/drf_sorter.cpp, lines 103-106
> > <https://reviews.apache.org/r/19090/diff/1/?file=517048#file517048line103>
> >
> >     Can you copy construct here?

Great idea! I've fixed everywhere else too.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19090/#review37267
-----------------------------------------------------------


On March 12, 2014, 5:04 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19090/
> -----------------------------------------------------------
> 
> (Updated March 12, 2014, 5:04 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-1086
>     https://issues.apache.org/jira/browse/MESOS-1086
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See bug for more description.
> 
> 
> Diffs
> -----
> 
>   src/master/drf_sorter.hpp f3fab71424fa10f87c87b733cc678fd90579a814 
>   src/master/drf_sorter.cpp bbf8270603e26a1b63e0f96bd5aa9c4ee4eb6d25 
> 
> Diff: https://reviews.apache.org/r/19090/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message