mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 19712: Replaced the element-swapping loop with RepeatedPtrField::DeleteSubrange() to remove a slave from the registry.
Date Thu, 27 Mar 2014 21:47:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19712/#review38819
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On March 27, 2014, 5:33 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19712/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 5:33 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> RepeatedPtrField::DeleteSubrange() has the same complexity but is cleaner.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp b6b9983464aea8ed45f62901d50da8ce118628cc 
> 
> Diff: https://reviews.apache.org/r/19712/diff/
> 
> 
> Testing
> -------
> 
> mesos-tests.sh --gtest_filter=Strict/RegistrarTest* --gtest_repeat=100
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message