mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 19743: Changed active_rules to array for easier management.
Date Thu, 27 Mar 2014 19:36:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19743/#review38794
-----------------------------------------------------------



support/mesos-style.py
<https://reviews.apache.org/r/19743/#comment71097>

    just curious. what are these rules testing?



support/mesos-style.py
<https://reviews.apache.org/r/19743/#comment71096>

    why not just
    
    rules_filter = '--filter=-+' + ',+'.join(active_rules)


- Vinod Kone


On March 27, 2014, 6:55 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19743/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 6:55 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary. Also added two trivial rules to check.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py 084690a207baa5d5f8f9273f10c67a642371908e 
> 
> Diff: https://reviews.apache.org/r/19743/diff/
> 
> 
> Testing
> -------
> 
> ? support/mesos-style.py 
> Checking 403 files using filter --filter=-,+whitespace/tab,+build/class,+build/deprecated
> Total errors found: 0
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message