mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 19248: Add support to move the slave into separate cgroups for monitoring
Date Thu, 27 Mar 2014 03:37:23 GMT


> On March 27, 2014, 12:10 a.m., Vinod Kone wrote:
> > src/slave/slave.cpp, lines 135-136
> > <https://reviews.apache.org/r/19248/diff/6/?file=537907#file537907line135>
> >
> >     Shouldn't we be only doing this if cgroups isolation is being used?

They are independent choices.


> On March 27, 2014, 12:10 a.m., Vinod Kone wrote:
> > src/tests/cluster.hpp, lines 516-518
> > <https://reviews.apache.org/r/19248/diff/6/?file=537910#file537910line516>
> >
> >     Why is non-existence a failure?

Because if the slave_subsystems flag is set it should've been created by the slave.


> On March 27, 2014, 12:10 a.m., Vinod Kone wrote:
> > src/tests/cgroups_tests.cpp, lines 149-157
> > <https://reviews.apache.org/r/19248/diff/6/?file=537909#file537909line149>
> >
> >     Why do you need this considering this is already being done in TearDown()?

To clean up if the tests are killed partway through, before TearDown can run.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19248/#review38680
-----------------------------------------------------------


On March 27, 2014, 1:35 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19248/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 1:35 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-327
>     https://issues.apache.org/jira/browse/MESOS-327
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This functionality is intended to support monitoring of the slave's resources, specifically
memory and cpu. This is done by moving the slave into a cpuacct and memory cgroup under $cgroups_hierarchy/{cpuacct,memory}/$cgroups_root/slave.
> 
> cgroup statistics will be of the slave itself plus any child process that isn't moved
to another cgroup, e.g., mesos-fetcher will be accounted but executors will not.
> 
> 
> Diffs
> -----
> 
>   src/local/local.cpp 2cfdf49c9eb92302502eb50c623f9606977b88b6 
>   src/slave/flags.hpp c9a627bc405a48da5d5ef9a90355970151fd6149 
>   src/slave/slave.cpp 0d712ee1f5351965d6643a8a984a347c61075876 
>   src/tests/allocator_tests.cpp 31cc8363fd647f3358d684b8a49b8bf657d94dd2 
>   src/tests/cgroups_tests.cpp 4a092cc5d60f1e9603c8524e686c71728da85f73 
>   src/tests/cluster.hpp 40d9f8c18307aead2374396710f9a82466e3a716 
>   src/tests/master_tests.cpp 39c8c23a8459d1bc7174e073221d7bb72f995bc8 
>   src/tests/mesos.cpp 96adeac27b0de691e0f30530f4bb4da4d3d0f842 
>   src/tests/resource_offers_tests.cpp cf910e5928bd7509139ec1b98459eb68a88065f1 
>   src/tests/slave_recovery_tests.cpp 40a9599787918b78790462e81729ec7ac2395509 
> 
> Diff: https://reviews.apache.org/r/19248/diff/
> 
> 
> Testing
> -------
> 
> make check # Linux, as root and non-root
> make check # OSX, as non-root only, see MESOS-812
> 
> 
> Thanks,
> 
> Ian Downes
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message