mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 19602: Added utility functions to get IPv4 address of a given link device.
Date Tue, 25 Mar 2014 20:43:40 GMT


> On March 25, 2014, 5:36 p.m., Cong Wang wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 384
> > <https://reviews.apache.org/r/19602/diff/1/?file=535060#file535060line384>
> >
> >     How does getifaddrs() handle multiple IP's on the same interface? At least on
Linux it is perfectly valid to have more than one IP addresses, for example one primary and
one secondary. I didn't figure this out thus chose to use ioctl() to get primary IP address
only.

This happens very rarely and we haven't seen it in real world. Not sure if it is only for
Linux because I don't know a way to add an IP address for a link device on OSX.

So, I will just change the comment saying that ip() returns the first available IP address
attached to the given link device, and added to TODO to track this problem.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19602/#review38468
-----------------------------------------------------------


On March 25, 2014, 5:35 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19602/
> -----------------------------------------------------------
> 
> (Updated March 25, 2014, 5:35 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong
Wang.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary. Will be used by the network isolator.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp b3d46d6 
>   3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19602/diff/
> 
> 
> Testing
> -------
> 
> make check on both OSX and Linux.
> 
> Also, manually verify the output with the output from ifconfig/ip addr show
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message