mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 19383: Implemented the Registry-backed Master.
Date Tue, 25 Mar 2014 00:11:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19383/#review38364
-----------------------------------------------------------

Ship it!


Add a TODO for adding a state variable in Slave struct instead maintaining a bunch of maps.


src/master/master.cpp
<https://reviews.apache.org/r/19383/#comment70458>

    Why did you kill the CHECK_NOTNULL()?



src/master/master.cpp
<https://reviews.apache.org/r/19383/#comment70459>

    s/unknown/non-activated/ ?



src/master/master.cpp
<https://reviews.apache.org/r/19383/#comment70460>

    s/unknown/non-activated/ ?



src/master/master.cpp
<https://reviews.apache.org/r/19383/#comment70479>

    


- Vinod Kone


On March 24, 2014, 7:35 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19383/
> -----------------------------------------------------------
> 
> (Updated March 24, 2014, 7:35 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-764
>     https://issues.apache.org/jira/browse/MESOS-764
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> This implements the Registry-backed Master, with the following exceptions that will be
addressed in follow up changes:
> 
> -Note that the --registry_strict flag is enforced to be false in master/main.cpp.
> -Reconciliation remains unimplemented as before.
> -Improvements can be made to killTask, specifically we should add SlaveID to the message
in order to drop fewer requests for unknown slaves.
> -Orthogonally, this does not address MESOS-682.
> 
> I've updated 'deactivated' slaves to be a cache of SlaveIDs rather than UPIDs as this
was the intent originally (we were concerned about the unbounded growth of the set, but cache<SlaveID,
Nothing> keeps a fixed capacity).
> 
> 
> Diffs
> -----
> 
>   src/master/constants.hpp cdaaad060d4ee777f8b0838b63c0fd031da861ea 
>   src/master/constants.cpp 18548834468243bef8ae090f70363e2b9f571ac5 
>   src/master/master.hpp a8ed5ec55766b7ecf3ed1368916da8b4b3e5bbe8 
>   src/master/master.cpp 90fd7b5f4b4e90e9f04c9120378f0cf1b9bd6a7c 
>   src/messages/messages.proto c26a3d0e69bbbd447c859cf175c139ab8948fde2 
>   src/slave/slave.cpp d8d3e0fa54972201d72b2650ec0ba922a4912d54 
> 
> Diff: https://reviews.apache.org/r/19383/diff/
> 
> 
> Testing
> -------
> 
> This change preserves the previous semantics and so all existing tests pass.
> 
> This is because the Registrar can only operate in a "non-strict" manner.
> 
> An unfortunate effect of this change is that many tests run slower due to the fact that
messages are dropped while we're recovering, an alternative approach here would be to re-enqueue
*all* incoming messages through recover(). However, this adds queuing delay to each message
processed in the Master and the performance implications of this are not well understood for
large clusters.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message