mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 19499: Ported slave statistics over to new metrics library.
Date Mon, 24 Mar 2014 16:39:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19499/#review38308
-----------------------------------------------------------



src/slave/slave.cpp
<https://reviews.apache.org/r/19499/#comment70351>

    .



src/slave/slave.cpp
<https://reviews.apache.org/r/19499/#comment70350>

    Please format these they way they were originally formatted.



src/slave/slave.cpp
<https://reviews.apache.org/r/19499/#comment70349>

    This introduces a race on frameworks, namely the metrics/statistics might try and 'get'
the value of this gauge while the master is simultaneously updating these values. We'll want
to be defer'ing here. This will definitely complicate the code in http.cpp, but that should
be deprecated anyway. One strategy here might be to just keep the old statistics and introduce
new metrics along side and then we can eventually drop the old stuff. Another idea might be
to introduce a call on gauge that returns the last cached value so it can be used synchronously
in http.cpp.



src/slave/slave.cpp
<https://reviews.apache.org/r/19499/#comment70353>

    Do we ever delete these? They will leak in tests.



src/slave/slave.cpp
<https://reviews.apache.org/r/19499/#comment70352>

    Whitespace.


- Benjamin Hindman


On March 20, 2014, 10:52 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19499/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 10:52 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1133
>     https://issues.apache.org/jira/browse/MESOS-1133
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp 594032da1b2edd47961cd8201acd093b22fa30ae 
>   src/slave/slave.hpp 01b80dfc1dd55edd6d2f722ff1d4f1bf4d96f28e 
>   src/slave/slave.cpp d8d3e0fa54972201d72b2650ec0ba922a4912d54 
> 
> Diff: https://reviews.apache.org/r/19499/diff/
> 
> 
> Testing
> -------
> 
> make check. ran locally and compared stats.json endpoint to /metrics/ endpoint.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message