mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 19542: Fixed a bug to properly re-register an authenticating framework.
Date Fri, 21 Mar 2014 20:46:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19542/#review38179
-----------------------------------------------------------


Nice catch. Just a couple of comments based on looking deeper into frameworks.activated (which
actually includes deactivated-but-not-completed frameworks too), framework->active, and
allocator->frameworkActivated.


src/master/master.cpp
<https://reviews.apache.org/r/19542/#comment70172>

    Since allocator->frameworkActivated() calls allocate(), shouldn't we make the frameworkActivated()
call after we "Remove any offers [previously] sent to this framework"? Otherwise, the allocate()
call (in frameworkActivated) might allocate/offer new resources and then the following loop
could call resourcesRecovered on the newly received offer/resources.



src/master/master.cpp
<https://reviews.apache.org/r/19542/#comment70179>

    Should we be setting framework->active = false; here? I know we're just moving it into
frameworks.completed, but none of those should think that they're "active".


- Adam B


On March 21, 2014, 11:42 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19542/
> -----------------------------------------------------------
> 
> (Updated March 21, 2014, 11:42 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-1135
>     https://issues.apache.org/jira/browse/MESOS-1135
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See bug for details.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 3b28f72be2016997e30649d2b12ed0e8f1a57dd5 
>   src/tests/fault_tolerance_tests.cpp 3f4796a0f5ed236d20906ee90e2cf8d30b5e228b 
>   src/tests/master_tests.cpp 42c5a77425209d96f8e7286102a672be50463a40 
> 
> Diff: https://reviews.apache.org/r/19542/diff/
> 
> 
> Testing
> -------
> 
> Updated 2 tests to verify the behavior.
> 
> make check
> 
> ./bin/mesos-tests.sh --gtest_filter="*FaultToleranceTest.FrameworkReregister*:*MasterInfoOnReElection*"
--gtest_repeat=1000 --gtest_break_on_failure
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message