mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Archana kumari" <archanakumari...@gmail.com>
Subject Re: Review Request 19389: Made strings to return constant references.
Date Thu, 20 Mar 2014 19:25:16 GMT


> On March 19, 2014, 5:50 p.m., Jiang Yan Xu wrote:
> > src/sasl/authenticatee.hpp, line 108
> > <https://reviews.apache.org/r/19389/diff/2/?file=526978#file526978line108>
> >
> >     Have we avoided any copying by doing this?
> >     
> >     From char* to string we are still copying, right?
> >     
> >     How does it compare to:
> >     
> >     promise.fail("Failed to initialize SASL: " +
> >                  std::string(sasl_errstring(result, NULL, NULL)));
> >

Jiang, only line no.108 and 168 are comparable

and 239 and 292 are seperately comparable


- Archana


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19389/#review37743
-----------------------------------------------------------


On March 19, 2014, 5:16 a.m., Archana kumari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19389/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 5:16 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   src/sasl/authenticatee.hpp 42a4eba 
> 
> Diff: https://reviews.apache.org/r/19389/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Archana kumari
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message