mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dominic Hamon" <dha...@twopensource.com>
Subject Re: Review Request 19336: Force disable C++11 in mesos for g++-4.7.
Date Wed, 19 Mar 2014 20:12:12 GMT


> On March 19, 2014, 12:18 p.m., Benjamin Hindman wrote:
> > configure.ac, line 287
> > <https://reviews.apache.org/r/19336/diff/5/?file=526616#file526616line287>
> >
> >     Can we easily print a warning message out? This seems a bit implicit for me,
especially if someone explicitly set --with-cxx11. I suppose, however, that the same was true
if someone explicitly set --without-cxx11 when using clang. Ideally if someone requests something
we fail rather than ignore their request just to "make it work".

in both the clang and g++ 4.7 we could fail with an error message if you prefer.

your comment suggests adding a warning and also failing so which would you like to see? i
agree a warning is the minimum required.


- Dominic


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19336/#review37764
-----------------------------------------------------------


On March 19, 2014, 12:10 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19336/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 12:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Bugs: MESOS-1095 and MESOS-1121
>     https://issues.apache.org/jira/browse/MESOS-1095
>     https://issues.apache.org/jira/browse/MESOS-1121
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   configure.ac 9a6de87fa6523bf8137f5d74ea0b7c6cbd947d3a 
>   m4/ax_compare_version.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19336/diff/
> 
> 
> Testing
> -------
> 
> make check GTEST_FILTER=''
> 
> clang, g++-4.4, g++-4.6, g++-4.7, g++-4.8; with and without c++11
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message